Filter out attributes that have names that start with RBX_

rojo-rbx · Aug 29, 2024 · b0fe238 · b0fe238
1 parent 65e02e7
commit b0fe238
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 0 deletions.
diff --git a/src/snapshot_middleware/json_model.rs b/src/snapshot_middleware/json_model.rs
@@ -100,6 +100,11 @@ fn json_model_from_pair<'sync>(
         match value {
             Variant::Attributes(attrs) => {
                 for (attr_name, attr_value) in attrs.iter() {
+                    // We (probably) don't want to preserve internal attributes,
+                    // only user defined ones.
+                    if attr_name.starts_with("RBX_") {
+                        continue;
+                    }
                     attributes.insert(
                         attr_name.clone(),
                         UnresolvedValue::from_variant_unambiguous(attr_value.clone()),

diff --git a/src/snapshot_middleware/meta_file.rs b/src/snapshot_middleware/meta_file.rs
@@ -85,6 +85,11 @@ impl AdjacentMetadata {
             match value {
                 Variant::Attributes(attrs) => {
                     for (attr_name, attr_value) in attrs.iter() {
+                        // We (probably) don't want to preserve internal
+                        // attributes, only user defined ones.
+                        if attr_name.starts_with("RBX_") {
+                            continue;
+                        }
                         attributes.insert(
                             attr_name.clone(),
                             UnresolvedValue::from_variant_unambiguous(attr_value.clone()),
@@ -266,6 +271,11 @@ impl DirectoryMetadata {
             match value {
                 Variant::Attributes(attrs) => {
                     for (name, value) in attrs.iter() {
+                        // We (probably) don't want to preserve internal
+                        // attributes, only user defined ones.
+                        if name.starts_with("RBX_") {
+                            continue;
+                        }
                         attributes.insert(
                             name.to_owned(),
                             UnresolvedValue::from_variant_unambiguous(value.clone()),

diff --git a/src/snapshot_middleware/project.rs b/src/snapshot_middleware/project.rs
@@ -537,6 +537,11 @@ fn project_node_property_syncback<'inst>(
         match value {
             Variant::Attributes(attrs) => {
                 for (attr_name, attr_value) in attrs.iter() {
+                    // We (probably) don't want to preserve internal attributes,
+                    // only user defined ones.
+                    if attr_name.starts_with("RBX_") {
+                        continue;
+                    }
                     attributes.insert(
                         attr_name.clone(),
                         UnresolvedValue::from_variant_unambiguous(attr_value.clone()),