Skip to content

Commit

Permalink
Demote unapplied patch warnings to debug logs (#805)
Browse files Browse the repository at this point in the history
These warnings always appear for properties like `Capabilities`,
`SourceAssetId`, etc. and tend to scare users who are syncing models.
This information is now surfaced in the patch visualizer, so I think
these warnings can be demoted to debug logs.
  • Loading branch information
kennethloeffler authored Oct 23, 2023
1 parent feac29e commit a3d1402
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions plugin/src/ServeSession.lua
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ function ServeSession:__initialSync(serverInfo)
local unappliedPatch = self.__reconciler:applyPatch(catchUpPatch)

if not PatchSet.isEmpty(unappliedPatch) then
Log.warn(
Log.debug(
"Could not apply all changes requested by the Rojo server:\n{}",
PatchSet.humanSummary(self.__instanceMap, unappliedPatch)
)
Expand All @@ -309,7 +309,7 @@ function ServeSession:__mainSyncLoop()
local unappliedPatch = self.__reconciler:applyPatch(message)

if not PatchSet.isEmpty(unappliedPatch) then
Log.warn(
Log.debug(
"Could not apply all changes requested by the Rojo server:\n{}",
PatchSet.humanSummary(self.__instanceMap, unappliedPatch)
)
Expand Down

0 comments on commit a3d1402

Please sign in to comment.