Keep the Vmlibrary.t type opaque. #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exposing the internal through Obj.magic is very fragile, and I do not think that accessing the VM bytecode is useful in practice. The corresponding code for declarations replaces the body by None anyways.
ejgallego
approved these changes
Feb 26, 2024
There was a problem hiding this comment.
LGTM.
Seraliziation of kernel environments was added to Serapi for the Coqgym paper, but indeed that has something we have never really fully supported, so I think that is OK.
[Actually I told the Coqgym people that they could have a better time not using kernel envs, but that's a different story]
It is very worrying tho that env now is not a pure data structure and can be mutated. That seems really risky to me.
|
Environments are still pure data structures, though. The table is just a binary tree. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up and clean-up of #389, after some pondering.
Exposing the internal through Obj.magic is very fragile, and I do not think that accessing the VM bytecode is useful in practice. The corresponding code for declarations replaces the body by None anyways.