Adds support for default values in required environment fields

[kanecko]

Implements #2012
Parent #2937

[kanecko]

I would love some documentation/pointers on unit/integration tests.
Especially, to which existing test-file should I add my tests and how do I run them?

[FroggyFlox]

Hi @kanecko ,

Thanks a lot for getting this going, and thank you especially for mentioning tests. I was actually going to add that to your milestone list as I believe we need to first establish some test coverage before we can add all these new features.

I'll try to get back with more details soon (unless someone near me to it, of course) as I'm a bit short on time at the moment but here are a few pointers real quick in case you haven't seen it already:
First, this would be for last when no more adjustments are needed anymore (if any):
https://rockstor.com/docs/contribute/contribute.html#database-migrations

Examples of testing and how to run them: I would have a look at the most recent work of that type by @phillxnet: #2925 (comment)

I'll get back with more shortly, hopefully, and thanks again. That's all exciting!

[phillxnet]

@kanecko Nice start. Could you move this to draft status, and to a named branch against the primary issue. This helps greatly with avoiding common mistakes when working on several things simultaneously. Which it looks like you may be doing shortly.

I.e. this PR is from your testing branch: better to have an issue specific branch. This will likely mean a re-submission, but not worries as you can reference this PR in the next one.

See our contributor guidelines on this here: https://rockstor.com/docs/contribute/contribute.html#developers

Named branches also help all-around to keep track of what a branch is supposed to be concerned with.

Great to have more eyes on the Rock-on code by the way.

[kanecko]

Thanks for the info.

@FroggyFlox I didn't explicitly mention or add tests there because I want to include them before moving on to the next milestone anyway.

@phillxnet I will resubmit the PR as instructed and with test code, thanks for the heads up.

This helps greatly with avoiding common mistakes when working on several things simultaneously. Which it looks like you may be doing shortly.

Actually, each milestone is a standalone, releasable improvement. I imagined my workflow would be to first complete (review+commit to rockstor/rockstore-core:testing) a task before moving on.
I'm somewhat new to git and github, so I don't know what the usual workflows are here. I don't mind creating new branches for each task, but I would prefer to complete a current task before moving on to the next one. I also prefer to do many small commits rather than one big one, because I can get early feedback.
Another reason why I prefer to commit directly to your testing branch is that I don't know if I'll be able to finish all the milestones by the end of my vacation. If I have to resume the work in a year, it would be great if I didn't have to merge changes that have happened in the meantime.