Add a test suite for cli commands, tests for rocketpool minipool status
#604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jshufro
force-pushed
the
jms/v2/testing-suite
branch
2 times, most recently
from
020a38d to
c98de71
Compare
jshufro
force-pushed
the
jms/v2/testing-suite
branch
from
c98de71 to
e78f954
Compare
jshufro
force-pushed
the
jms/v2/testing-suite
branch
from
e78f954 to
f9e9cbf
Compare
0xfornax
reviewed
Jul 22, 2024
0xfornax
approved these changes
Jul 24, 2024
jshufro
force-pushed
the
jms/v2/testing-suite
branch
from
55ed70f to
61680a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test suite is simple still, and only really works for commands that result in a single http request to the daemon.
Merging is blocked by #595 and includes those commits, so maybe don't review this PR yet.