-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add information about testing in workspace and components #58
Conversation
@henriquejsfj could you have a read ? I'm very aware that it's probably hard to understand how to understand all of this ... I'd be very glad for a thorough review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good! I never used workspace tests with cmake tests and all but the explanation seems to be enough.
Nice. You probably will have more comments once you've actually written the tests of the websocket controldev task, let's wait until then before merging this. |
Pretty comprehensive... I missed one common case though: testing that ONE output port sends TWO samples in a row. I remember I needed this once and I couldn't manage, ended up creating a socket in my tests and connecting the iodriver's base subject to it by setting task.properties.io_port I mean something like: expect_execution { task.set_and_check_something }
.to do
[have_one_new_sample(task.io_raw_out_port),
have_one_new_sample(task.io_raw_out_port)]
end |
In hindsight, a rather obvious need, actually. Would need to refactor the Added an issue on syskit rock-core/tools-syskit#232 |
Thanks... 👍 |
No description provided.