Dev presets #46
Dev presets #46
Conversation
Added usePreset check before trying to applying them
|
@SimoneMic we found this branch used on ergoCubSN000, is this PR ready for review and merge, so we use a released version of yarp-device-realsense2 ? Thanks! fyi @Nicogene |
|
I have tested this repo only with |
|
Otherwise @traversaro you can use the previous master version, is still viable, since this is only an improvement for the navigation |
|
@SimoneMic sorry for the delay, are you still using this modification? Should we try to merge it? |
|
Yes, I'm still using it |
| m_usePreset = config.find("usePreset").asBool(); | ||
| yCInfo(REALSENSE2) << "Enabled Using Presets"; | ||
| } | ||
| else |
| std::string presetName = config.find("presetName").asString(); | ||
| std::transform(presetName.begin(), presetName.end(), presetName.begin(), ::toupper); | ||
| if (presetsMap.find(presetName) == presetsMap.end()) { | ||
| yCError(REALSENSE2) << "Value " << presetName << " not allowed as camera preset, see documentation for supported values."; |
There was a problem hiding this comment.
Is it ok that this is not a fatal error?
The log of such devices usually is not checked and the user may expect to have the presets enabled if the device is correctly running
| @@ -149,5 +159,7 @@ class realsense2Driver : | |||
| float m_scale; | |||
| bool m_rotateImage180{false}; | |||
| std::vector<cameraFeature_id_t> m_supportedFeatures; | |||
| bool m_usePreset{false}; | |||
There was a problem hiding this comment.
Can you please add this new flag in the documentation ? In the README is sufficient
|
I looked into this as well, and I was a bit worried about some aspects:
|
Added the possibility to set camera presets for 400 camera series.
In this link the general documentation from Intel.
Here the SDK docu