Add log support for dedicated deployment #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigbitbus
reviewed
Oct 30, 2024
roboflow/deployment.py
Outdated
| if log["insert_id"] in log_ids: | ||
| continue | ||
| log_ids.add(log["insert_id"]) | ||
| print(f'[{datetime.fromisoformat(log["timestamp"]).strftime("%Y-%m-%d %H:%M:%S.%f")}] {log["payload"]}') |
There was a problem hiding this comment.
In what form is the log["payload"]? Is it always plaintext or can it be json too?
There was a problem hiding this comment.
it can be either text or json, but in our inference server, it only generate texts (no structured log, because it's not tied to any cloud provider)
There was a problem hiding this comment.
confirmed that the f string support dict (json) as well
roboflow/deployment.py
Outdated
| status_code, msg = deploymentapi.get_deployment_log(api_key, args.deployment_name, from_timestamp, to_timestamp) | ||
| if status_code != 200: | ||
| print(f"{status_code}: {msg}") | ||
| return |
There was a problem hiding this comment.
We should return a non-zero exit to the cli command when there is an error, this is useful in using the command in a script.
bigbitbus
reviewed
Oct 30, 2024
| deployment_log_parser.add_argument( | ||
| "-d", "--duration", help="duration of log (from now) in seconds", type=int, default=3600 | ||
| ) | ||
| deployment_log_parser.add_argument("-f", "--follow", help="follow log output", action="store_true") |
There was a problem hiding this comment.
Is it worth having a flag to show the last n lines of the log?
There was a problem hiding this comment.
Good idea! Added
…boflow-python into dedicated-deployment-add-log
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add log support for dedicated deployment.
Type of change
Please delete options that are not relevant.
How has this change been tested, please provide a testcase or example of how you tested the change?
Tested locally.
Any specific deployment considerations
For example, documentation changes, usability, usage/costs, secrets, etc.
Docs