Changed upload_dataset into taking project_id instead of project_name #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artyaltanzaya
requested review from
tonylampada
and removed request for
tonylampada
bigbitbus
approved these changes
Dec 1, 2023
tonylampada
reviewed
Dec 1, 2023
roboflow/core/workspace.py
Outdated
| return ( | ||
| self.create_project( | ||
| project_name, | ||
| project_id, |
There was a problem hiding this comment.
maybe do
self.create_project(
project_name=project_id,to make it more explicit?
|
@artyaltanzaya also, before releasing, we need to manually increase the version number in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Function
upload_datasetuses project_name to check for existing project, changed it to using project_idType of change
Please delete options that are not relevant.
How has this change been tested, please provide a testcase or example of how you tested the change?
YOUR_ANSWER
Any specific deployment considerations
For example, documentation changes, usability, usage/costs, secrets, etc.
Docs