Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Configuration UI #1018

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Improve Configuration UI #1018

wants to merge 3 commits into from

Conversation

yne
Copy link

@yne yne commented Dec 23, 2023

This PR:

  • Group configuration by categories
  • Allow simple array and object modification from UI using the VScode "Add Item" action

How:

  • By declaring an array of categories (each category contain the same "properties" values as before)
  • By adding an additionalProperties attribute on object/list configurations params
  • By updating the relevant intellij/package python generator

Preview:

Untitled (1)

Verification

Because of the new indentation level, this PR has a lot of changed lines,
In order to check that all attributes are still here from the previous package.json we can

diff \
<(jq '.contributes.configuration[].properties | keys[]' < package.json | sort)\
<(jq '.contributes.configuration.properties|keys[]' < package_ori.json | sort)

- Group configuration by categories
- Allow simple array and object modification from UI
@CLAassistant
Copy link

CLAassistant commented Dec 23, 2023

CLA assistant check
All committers have signed the CLA.

@fabioz
Copy link
Collaborator

fabioz commented Feb 21, 2024

Sorry for the really late reply (I just saw this PR now).

Actually the package.json is generated from running robotframework-lsp/codegen/codegen_package.py, so, it cannot be changed directly (you need to update the code that generates it...).

@yne
Copy link
Author

yne commented Feb 22, 2024

@fabioz
good to know, I'll take a look

@yne
Copy link
Author

yne commented Feb 23, 2024

@fabioz : I've updated the relevant generator in 617dd1d then run a pass of generation that I've put in a 3rd commit 7f9fadc

Tell me if I forgot any other files :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants