UPDATED DOCS

[vaibhawkhemka]

Updated Installation of package "pickle" and minor fixes.
Please review this. @orensbruli @pbustos @adityaaggarwal97

[orensbruli]

@vaibhawkhemka Thank you for your contribution.
You are committing to the master branch and we all work on the development one as said in the README on the main page. Check if some of the changes you are suggesting apply to the development branch.

[vaibhawkhemka]

Hello Esteban, robocomp-robolab doesn't have development branch. Can u please guide/correct me if I am wrong?

…

On Mon, Mar 22, 2021, 12:18 PM Esteban Martinena Guerrero < ***@***.***> wrote: @vaibhawkhemka <https://github.com/vaibhawkhemka> Thank you for your contribution. You are committing to the master branch and we all work on the development one as said in the README on the main page. Check if some of the changes you are suggesting apply to the development branch. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#65 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALDB2OWXGHFYV2QSVCFZTKLTE3R5VANCNFSM4YBKJY4A> .

[orensbruli]

You are right! My fault. I guess I'm looking too quick into the PRs!

[orensbruli]

Also, for the next time, I recommend making smaller PR. It's easy to get your files reviewed for someone related.

[orensbruli]

I see several new files in your PR. Are those for a new component? What is it for? Is it for some specific GSoC 2021 idea? Have you already tested?

[vaibhawkhemka]

Yes, those are new components for depth estimation. And it is among one of the Gsoc idea and have already tested it. And further improving the model for making it more efficient and will be adding some more features.

…

On Mon, Mar 22, 2021, 2:06 PM Esteban Martinena Guerrero < ***@***.***> wrote: I see several new files in your PR. Are those for a new component? What is it for? Is it for some specific GSoC 2021 idea? Have you already tested? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#65 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALDB2OR5GRMU5QQM5IJJ7Q3TE36QBANCNFSM4YBKJY4A> .

[orensbruli]

Perfect!
And whose are the mentors of that idea? @pbustos and @adityaaggarwal97 ? If they are we will wait until they review this. If not, I suggest you to invite them to review this PR.
Thank you!

[vaibhawkhemka]

Mentors are Mohamed shawky and Luis Vicente Calderita for "Monocular Depth Estimation from RGB signals". I will invite them for reviewing the PR. Thanks

…

On Mon, Mar 22, 2021, 2:21 PM Esteban Martinena Guerrero < ***@***.***> wrote: Perfect! And whose are the mentors of that idea? @pbustos <https://github.com/pbustos> and @adityaaggarwal97 <https://github.com/adityaaggarwal97> ? If they are we will wait until they review this. If not, I suggest you to invite them to review this PR. Thank you! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#65 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALDB2OU56F3DAAT2IQCP75TTE4AJJANCNFSM4YBKJY4A> .

[vaibhawkhemka]

Hello @orensbruli, I have added all the final updated files for depth estimation in robocomp-robolab in a new PR ("MONOCULAR DEPTH ESTIMATION USING RGB IMAGES") to make it easier for testing them to give the real time prediction of depths. Thanks On Mon, Mar 22, 2021, 2:34 PM vaibhaw khemka ***@***.***> wrote:

…

Mentors are Mohamed shawky and Luis Vicente Calderita for "Monocular Depth Estimation from RGB signals". I will invite them for reviewing the PR. Thanks On Mon, Mar 22, 2021, 2:21 PM Esteban Martinena Guerrero < ***@***.***> wrote: > Perfect! > And whose are the mentors of that idea? @pbustos > <https://github.com/pbustos> and @adityaaggarwal97 > <https://github.com/adityaaggarwal97> ? If they are we will wait until > they review this. If not, I suggest you to invite them to review this PR. > Thank you! > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#65 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ALDB2OU56F3DAAT2IQCP75TTE4AJJANCNFSM4YBKJY4A> > . >

[orensbruli]

What is this change for?

[vaibhawkhemka]

This is an updated command for installing pickle library

[orensbruli]

So, this PR is obsolete

Hello @orensbruli, I have added all the final updated files for depth estimation in robocomp-robolab in a new PR ("MONOCULAR DEPTH ESTIMATION USING RGB IMAGES") to make it easier for testing them to give the real time prediction of depths. Thanks On Mon, Mar 22, 2021, 2:34 PM vaibhaw khemka @.> wrote:
…
Mentors are Mohamed shawky and Luis Vicente Calderita for "Monocular Depth Estimation from RGB signals". I will invite them for reviewing the PR. Thanks On Mon, Mar 22, 2021, 2:21 PM Esteban Martinena Guerrero < @.> wrote: > Perfect! > And whose are the mentors of that idea? @pbustos > https://github.com/pbustos and @adityaaggarwal97 > https://github.com/adityaaggarwal97 ? If they are we will wait until > they review this. If not, I suggest you to invite them to review this PR. > Thank you! > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#65 (comment)>, > or unsubscribe > https://github.com/notifications/unsubscribe-auth/ALDB2OU56F3DAAT2IQCP75TTE4AJJANCNFSM4YBKJY4A > . >

Is this PR obsolete? Is the title right? It's a full component or documentation PR?
Thank you.

[vaibhawkhemka]

Yes, this PR is obsolete now. Sorry for the confusion. The component part has been merged into https://github.com/robocomp/DNN-Services and documentation related to "Pickle and Argument parser" has been updated to #66. Thus, Closing this PR.