Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 1.4? #27

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Update 1.4? #27

wants to merge 10 commits into from

Conversation

ShadowCCS
Copy link

Update Log

New Save System: Implemented a new save system using Properties, making it easier to maintain and use. No privacy concerns are involved with this type of saving.

Custom Themes: Introduced a flexible theming system that allows users to create and share fully custom themes, moving beyond just light and dark modes. This update includes five default themes: Light, Dark, Nature, Earth, and Glass. Theme .xaml files now control more UI elements for enhanced customizability.

New Features:

"Hold" Click Type: Added a new "Hold" option as a click type for more interactive control.

"Save All Settings" Option: Based on user feedback, a new setting was added that enables automatic saving of all user inputs.
Improved Visual Feedback: Additional visual cues have been introduced to better indicate when clicking is active. A dot and text in the top-left corner provide clearer status, addressing issues in certain themes where it was hard to tell from the start/stop buttons alone.

Jittering: Introduced a jittering feature to make movements appear more human-like. It works with custom coordinates by altering the location, delay, and interpolation of movements to mimic human behavior. Some applications may detect this form of automated clicking. Users can adjust the level of jittering in the settings menu on a scale of 0 (disabled) to 5 (maximum jittering).

Keybinding Fix: Fixed an issue where special keys would crash the application in the keybinding section.

Process Selection: Began development of process selection functionality (currently incomplete and marked out due to functionality issues).

Bug Fixes: Addressed several minor bugs to improve overall stability.

@ShadowCCS
Copy link
Author

Bugs to be fixed:

  • When applying a theme sometimes the start and stop buttons won't be updated until interacted with
  • The get position window can work unexpectedly on some computers, the location is correct, but the position of the window itself might have a different follow position than it should
  • Within the change hotkey tab the switching process can hang and cause some weird interactions if trying to change the hotkey multiple times in fast succession or using unknown keys (can leave the hotkey empty)
  • Clicking "OK" within the "Change Hotkey" tab will call a debug message box telling what key is chosen. This should be removed.

Should be fixed in the coming days

@ShadowCCS
Copy link
Author

I have patched the issues above, let me know if you want the updated program

Copy link
Owner

@robiot robiot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Left a review with some things you need to change. I also need to test it then

Keep in mind,
We want to keep AlphaClicker independent, not dependent on external software. If features from AHK is wished, implement them directly with the win32 api, not by proxing through ahk.

@@ -1,59 +1,48 @@
# Alpha Clicker 1.4
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't reformat the whole Readme. Keep format. And don't have your new PR updates here as they belong in PR comments.

Keep the readme as before, with changes to reflect the new features

}


//private void CheckAHKInstalled() //A external program that could potentially handle process selection and clicking, it is currently disabled due to issues, but is left here currently
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't keep this. We dont want to rely on ahk


private void windowSettings_Loaded(object sender, RoutedEventArgs e)
{
//Irelevant, previously used
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

JitterSelector.SelectedIndex = 0; // Assuming 0 (None) is the default
}

//string processName = Properties.Settings.Default.ProcessName;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove comments

using System.IO;
using System.Text;

public class IniFile
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesnt seem to be used anywhere

@@ -32,19 +32,23 @@
<RowDefinition Height="7*"/>
</Grid.RowDefinitions>

<Label Content="Click Or Press Esc To Pick"
<Label Content="Click to select or ESC to cancle"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cancel*


private void InstallButton_Click(object sender, RoutedEventArgs e)
{
string url = "https://www.autohotkey.com/download/ahk-v2.exe"; // Autohotkey download
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to keep AlphaClicker idendependent, not dependent on external software. If features from AHK is wished, implement them directly with the win32 api, not by proxing through ahk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants