Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] First release #13

Open
wants to merge 240 commits into
base: master
Choose a base branch
from
Open

[WIP] First release #13

wants to merge 240 commits into from

Conversation

rlee287
Copy link
Owner

@rlee287 rlee287 commented Feb 9, 2020 •
edited
Loading

Tasks left:

  • Implement QAM
  • Code cleanup
  • Documentation
  • Finalize YAML format for this version

rlee287 added 30 commits October 20, 2019 11:32
@rlee287
Add initial type stubs
ce0c5f9
@rlee287
Merge branch 'develop' into create_type_stubs
c64c7b7
@rlee287
Create mypy stub for encode_pad
bf782e0
@rlee287
Add mypy typecheck to 3.7 after success
d502b3d
@rlee287
Create custom script for running mypy checks
37dc3c7
@rlee287
Remove non-POSIX pushd and popd from mypy script
f82f5f0
@rlee287
Try adding back in Python 3.8 to Travis
986dcf7
@rlee287
Try installing liblapack-dev to allow scipy building
e726c86
@rlee287
See if pypy3 also works
0370c81
@rlee287
Make modulator a proper abstract class
ff91ce6
@rlee287
Give types to the generate_timearray static method
ba88f8c
@rlee287
Move samples_per_symbol helper into base modulator class
432d899
@rlee287
Update base modulator typestub
caec8e7
@rlee287
Merge branch 'create_type_stubs' into develop
b0e6a6a
@rlee287
Add ending newlines to some files
67a4b6e
@rlee287
Minor cleanup of ECC test
d6d8464
@rlee287
[ci skip] Update gitignore to ignore provisional stubgen pyi files
41bab10
@rlee287
Convert all dt references to fs references
2258e07 
Code still not tested and therefore assumed buggy (at least for now)
@rlee287
Move helper static methods to be functions
7d6d320
@rlee287
Remove WROG annotation from FSK
9ed0b1d
@rlee287
Convert gaussian window to fs and add docstrings
d17a491
@rlee287
Create integral averaging function in modulator utils
0e905c7
@rlee287
Skeleton of ASK modulator
e907ddf
@rlee287
Use linspace instead of arange for timearray generation
d540d35
@rlee287
Write some tests for modulator utils
407ad45 
TODO: finish tests
@rlee287
Fix average function bugs and add bounds checking
7b0eb3b
@rlee287
Write more tests for the average function
fcb8a86
@rlee287
Add property test for average using triangular area under function
76edb56
@rlee287
Check for special case of width=0 when averaging
80bdbdb
@rlee287
Add test for when bounds are equal
2908570
rlee287 added 15 commits April 7, 2020 11:38
@rlee287
Finish writing QAM Modulator notebook
7a326c9
@rlee287
Add positive frequency check to all modulators
14141b7
@rlee287
[ci skip] Update Pipfile.lock dependencies
8571b07
@rlee287
Extend demodulated signal with filt_delay padding
d9b5281 
Very lucky that my filter was small enough for me not to lose the end symbols...
@rlee287
Fix signal name typo in ASK modulator
28534f7
@rlee287
Add fs as an expected instance variable in the BaseModulator abstract…
f9c14f5 
… class

MyPy check_untyped_defs can now be enabled with this last issue out of the way
@rlee287
Turn PSKModulator into a thin wrapper around QAMModulator
8972923
@rlee287
Adjust type hint to work with Python 3.5
339ea22
@rlee287
Add tests that check for exception on negative carrier
8d1dfab
@rlee287
Merge branch 'qam' into develop
1cee8f5
@rlee287
Update config script to state that QAM is now supported
1efc510
@rlee287
Raise ValueError upon encountering bad modulator type in examples
5f6d4a8
@rlee287
Check all example configs in CLI roundtrip modulation test
890e5da
@rlee287
Add test for corruption response upon demodulation
9718102
@rlee287
Write docstrings for the bitstream+datastream functions
11d7e25
@rlee287
Copy link
Owner Author

rlee287 commented May 14, 2020

Holding off on finalizing the YAML until #14 is implemented. Raised cosine filters are better to the point that this should be the default, but they need to be implemented first.

rlee287 added 14 commits May 14, 2020 15:39
@rlee287
Add checks modulator utils to ensure positive inputs
7632e93
@rlee287
Continue polishing Jupyter Notebook documentation
455ec27
@rlee287
Adjust docstrings for base modulator object
f5a1aee
@rlee287
Add back the ignoring of warnings in ASK unit tests
331263e 
Forgot why I put them there originally-oops
@rlee287
Adjust tests for negative parameters in filter utilities
054a618
@rlee287
Ignore warnings for fsk_integrity_high_pitch (again)
f4acf2a
@rlee287
Parallelize property tests with pytest-cov and pytest-xdist
fb68613
@rlee287
Add new dev dependencies to Travis list
34a8bb9
@rlee287
Include upgrade command in travis dev dependencies
a638d7c
@rlee287
Add the interval offset to the end location in demodulation loops
7102bf3
@rlee287
Use overlap-add convolution method for demodulation filtering
9c98c26
@rlee287
Enforce SciPy>=1.4.0 and update Pipfile.lock accordingly
31bdb8b
@rlee287
Remove filename clash in unit tests, allowing them to be run in parallel
fb4ff0a
@rlee287
Simplify bitstream read slightly and add tests
21629fe 
(cherry picked from commit b2d71be2017d76dcc9467ecb303fd77e22071488)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rlee287