-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Mock.Of<T> and MockRepository support to ConstructorArgumentsShouldMatchAnalyzer #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated to refactor a bit so the shipping analyzer analyzer would correctly fire
rjmurillo
added
documentation
analyzers
Change that impacts an analyzer behavior
releasable
feature
labels
Jul 5, 2024
MattKotsenas
previously approved these changes
Jul 8, 2024
Code Climate has analyzed commit 70cd7a8 and detected 37 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The majority of this change is mechanical (moving code from one location to another, replacing magic strings with constants, etc.). There is a functional update that completely changes the
ConstructorArgumentsShouldMatchAnalyzer
:Mock.Of<T>
andMockRepository
features ofMoq
Baseline is an empty analyzer, control is the old interface constructor parameter analyzer, treatment is the new combined analyzer.
Changes
Misc:
Common
folder and namespaceDocumentation:
Analyzers:
Diagnostic
ConstructorArgumentsShouldMatchAnalyzer
now supportsMock.Of<T>
syntax andMockRepository
patternsBenchmarks:
ConstructorArgumentsShouldMatchAnalyzer
Test:
ConstructorArgumentsShouldMatchAnalyzer
test collateral (it's the highest volume) into partial filesNote: while code coverage is improved, it's still below 95%. This is due to some guard cases that need coverage. For example, #141
Resolves #122
For Moq1001 and Moq1002, #85