-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Moq.Analyzers.Benchmarks with a single sample benchmark #109
Merged
MattKotsenas
merged 13 commits into
rjmurillo:main
from
MattKotsenas:feature/perf-harness
Jun 21, 2024
Merged
Add Moq.Analyzers.Benchmarks with a single sample benchmark #109
MattKotsenas
merged 13 commits into
rjmurillo:main
from
MattKotsenas:feature/perf-harness
Jun 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit cfd9b11. Doing it this way doubles the test case time and reduces the ration between test and baseline compared to doing it ourselves.
rjmurillo
approved these changes
Jun 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Step 2 would be getting this to show up in the action and building gates. Thanks for also taking care of some of those other warnings
Here's a sample of the output:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the project
Moq.Analyzers.Benchmarks
with a sample benchmark for diagnostic Moq1300. This pattern is copied from https://github.com/dotnet/roslyn-analyzers/blob/f1115edce8633ebe03a86191bc05c6969ed9a821/src/PerformanceTests/Tests/Enabled/CSharp_CA1416.cs, but where possible I used the types exposed by the Microsoft.CodeAnalysis.*.Testing libraries instead.As part of the exercise, I filed dotnet/roslyn-sdk#1165 to discuss if some of these helpers should move into the testing packages, and / or to document any existing profiling best practices.
This change doesn't attempt to hook the benchmarks into CI in any way; they're both currently too slow for that, and I'm not yet sure what (if anything) to gate on.