Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not bring main window to foreground upon file change #5320

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

lhmouse
Copy link
Contributor

@lhmouse lhmouse commented Nov 11, 2024

It's very disrupting, especially when tail mode or auto reload has been turned on.

It's very disrupting, especially when tail mode or auto reload has
been turned on.

Signed-off-by: LIU Hao <[email protected]>
@hpwamr hpwamr merged commit 8c5ea87 into rizonesoft:master Nov 12, 2024
1 check passed
@hpwamr
Copy link
Collaborator

hpwamr commented Nov 12, 2024

Hello @lhmouse ,
All your updates are merged. 👍
I will release a new RC3 build in a few days.

@lhmouse
Copy link
Contributor Author

lhmouse commented Nov 12, 2024

Thanks. I've been curious about when a new release will come out. 🥺

@hpwamr
Copy link
Collaborator

hpwamr commented Nov 12, 2024

Thanks. I've been curious about when a new release will come out. 🥺

Hello @lhmouse ,
In the meantime, I suggest to testing your PR by replacing the "Notepad3.exe" with the Appveyor raw build artifacts that you can find here (expires after 2024-Dec-12): https://ci.appveyor.com/project/rizonesoft/notepad3/build/job/5n3ms5516lapsm5o/artifacts

@lhmouse
Copy link
Contributor Author

lhmouse commented Nov 12, 2024

Actually I built it locally.

@avih
Copy link

avih commented Nov 21, 2024

@lhmouse thanks for making NP3 not steal the focus. That was indeed highly annoying.

If you care and want to look into it, I posted some further potential improvements here #5325 (comment) . At least one of those seems entirely trivial (I don't have visual studio installed to test changes and then open PRs. Yes, I know it's free).

Thanks again.

@hpwamr
Copy link
Collaborator

hpwamr commented Nov 25, 2024

I will release a new RC3 build in a few days.

Hello @lhmouse ,

Feel free to test the "BETA/RC PortableApps", version "Notepad3Portable_6.24.1125.1_rc3.paf" or newer, see the 1st list in issue #1129.

"Notepad3Portable BETA/RC PortableApps" version can be used with or without ".7z" extension.

Also, feel free to test the "BETA/RC Setup", version "Notepad3_6.24.1125.1_rc3_Setup" or newer, see the 2nd list in issue #1129.

Comments and suggestions are welcome... 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants