Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Salus-TSM stub #129

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+646 −557
Open

Add Salus-TSM stub #129

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
70e8430
Add salustsm feature flag
atulkharerivos Oct 7, 2022
e8d061a
Refactor host_vm functionality
atulkharerivos Oct 8, 2022
9fe3d8f
Add Salus TSM module
atulkharerivos Oct 8, 2022
feaed3d
Add Salus TSM build target
atulkharerivos Oct 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@ strip = "debuginfo"
codegen-units = 1
panic = "abort"

[features]
salustsm = []
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there are separate binary targets, do we still need a feature flag? If we want a feature flag + separate binary targets, is there a way to automatically set the feature based on which binary we're building?

Also some bikeshedding: I feel like "tsm_only" is a better name than "salustsm", as it's more obvious what the flag is doing (stripping out the non-TSM components).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feature flags can be enabled by default, but it does require the flag to be defined AFAIK. The nomenclature was arbitrary, so perhaps, we can just see what feels best in the channel.


[dependencies]
arrayvec = { version = "0.7.2", default-features = false }
assertions = { path = "./assertions" }
Expand Down