Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: rename e2e-test to e2e-test-serial #19942

Merged
merged 1 commit into from
Dec 27, 2024
Merged

ci: rename e2e-test to e2e-test-serial #19942

merged 1 commit into from
Dec 27, 2024
+11 −16

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Dec 26, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

prepare for #18992

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

@xxchan xxchan requested a review from BugenZhao December 26, 2024 09:02
xxchan
xxchan commented Dec 26, 2024
View reviewed changes
ci/scripts/cron-e2e-test.sh
set -euo pipefail

source ci/scripts/common.sh
export RUN_COMPACTION=0;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems we forgot to re-enable it.
#14367 (comment)

@xxchan xxchan enabled auto-merge December 26, 2024 09:30
@graphite-app graphite-app bot requested a review from a team December 26, 2024 09:38
BugenZhao
BugenZhao approved these changes Dec 27, 2024
View reviewed changes
Copy link
Member

@BugenZhao BugenZhao left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the goal is to only include non-parallalizable tests in this step?

@xxchan xxchan added this pull request to the merge queue Dec 27, 2024
Merged via the queue into main with commit 05397f9 Dec 27, 2024
29 of 30 checks passed
@xxchan xxchan deleted the xxchan/creative-mosquito branch December 27, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BugenZhao BugenZhao BugenZhao approved these changes

Assignees
No one assigned
Labels
component/ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xxchan @BugenZhao