Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add a complex nested type test #19940

Merged
merged 1 commit into from
Dec 26, 2024
Merged

test: add a complex nested type test #19940

merged 1 commit into from
Dec 26, 2024
+11 −10

Conversation

chenzl25
Copy link
Contributor

@chenzl25 chenzl25 commented Dec 26, 2024 •
edited
Loading

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

@chenzl25 chenzl25 requested review from xxchan and ZENOTME December 26, 2024 07:38
@github-actions github-actions bot added the component/test Test related issue. label Dec 26, 2024
@chenzl25 chenzl25 requested a review from Li0k December 26, 2024 07:38
@graphite-app graphite-app bot requested a review from a team December 26, 2024 08:15
xxchan
xxchan approved these changes Dec 26, 2024
View reviewed changes
Copy link
Member

@xxchan xxchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh great. So we can close #18484 now

@chenzl25 chenzl25 added this pull request to the merge queue Dec 26, 2024
Merged via the queue into main with commit b13d5e9 Dec 26, 2024
37 of 38 checks passed
@chenzl25 chenzl25 deleted the dylan/add_complex_nested_type_test_for_iceberg_engine_table branch December 26, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xxchan xxchan xxchan approved these changes

@ZENOTME ZENOTME Awaiting requested review from ZENOTME

@Li0k Li0k Awaiting requested review from Li0k

Assignees
No one assigned
Labels
ci/run-e2e-iceberg-engine-tests component/test Test related issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

iceberg sink: nested type inside another nested type is not supported
2 participants
@chenzl25 @xxchan