Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(barrier): broadcast actor info to newly added node #19939

Merged
merged 2 commits into from
Dec 27, 2024

Conversation

wenym1
Copy link
Contributor

@wenym1 wenym1 commented Dec 26, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Root cause of #19536.
Resolve #19884

Previously for newly added node, we won't broadcast the existing actor info to the node. When actors that are spawned later on this node try to get the actor info in other nodes, it will get the actor id not found error.

In this PR, we fix this by including all the existing actor infos in the initial request for the newly add node.

By the way, we also change the way to broadcast inflight subscription infos in recovery. Previously in recovery, we include the existing subscription infos in the initial request to CN. It works in global recovery, but in per-database recovery, we will not send this initial request, and then the existing subscriptions will be missed in the recovered database. In this PR, we change to broadcast the existing subscription infos in the initial inject barrier request. In this way, we can also broadcast the existing subscriptions in per-database recovery.

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

Copy link
Contributor

@shanicky shanicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Thanks!

cc @yezizp2012

@wenym1 wenym1 added this pull request to the merge queue Dec 27, 2024
Copy link
Member

@yezizp2012 yezizp2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Merged via the queue into main with commit fdd2493 Dec 27, 2024
39 of 41 checks passed
@wenym1 wenym1 deleted the yiming/broadcast-actor-info-to-new-node branch December 27, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The brand new worker does not have any existing ActorInfo for the actors.
3 participants