Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(snapshot-backfill): extract common logic of consuming snapshot and log store #19936

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wenym1
Copy link
Contributor

@wenym1 wenym1 commented Dec 25, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Part of #19720.

For snapshot backfill, in the main branch and the future PR #19720, the stage of consuming snapshot and consuming log store have the similar logic of consuming a stream of row with op and convert the stream into stream chunk. In this PR, we will extra the common logic and let them share the same code.

Previously, the row streams of multiple vnodes are combined in the stream returned from StorageTable method. In this PR we will change to combine the stream of multiple vnodes outside StorageTable with FuturesUnordered, so that we can access each vnode stream and get the progress of each vnode, which will be useful in #19720.

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

Base automatically changed from yiming/lazily-remove-uploader-instance-data to main December 25, 2024 09:15
@wenym1 wenym1 force-pushed the yiming/snapshot-backfill-vnode-stream branch from 2d2947f to 579b264 Compare December 25, 2024 09:49
@wenym1 wenym1 requested review from hzxa21 and kwannoel December 26, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant