Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove file_cache_bench and s3_bench #19927

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: remove file_cache_bench and s3_bench #19927

wants to merge 1 commit into from
+0 −1,452

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Dec 24, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

They are old and unmaintained. (>2years)

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

@xxchan xxchan requested a review from a team as a code owner December 24, 2024 16:21
@xxchan xxchan requested a review from hzxa21 December 24, 2024 16:21
xxchan
xxchan commented Dec 24, 2024
View reviewed changes
src/bench/Cargo.toml
Comment on lines 43 to 45
[[bin]]
name = "sink-bench"
path = "sink_bench/main.rs"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @xxhZs is sink_bench still useful?

@xxchan xxchan requested review from MrCroxx and xxhZs December 24, 2024 16:21
@xxchan Graphite App
Copy link
Member Author

xxchan commented Dec 24, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@xxchan xxchan mentioned this pull request Dec 24, 2024
Open
8 tasks
@xxchan xxchan enabled auto-merge December 24, 2024 17:09
@xxchan xxchan disabled auto-merge December 24, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hzxa21 hzxa21 Awaiting requested review from hzxa21 hzxa21 is a code owner automatically assigned from risingwavelabs/cargo-lock

@MrCroxx MrCroxx Awaiting requested review from MrCroxx

@xxhZs xxhZs Awaiting requested review from xxhZs

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
type/chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@xxchan