Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(metric): include table change log when calculating Hummock version size #19920

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

zwang28
Copy link
Contributor

@zwang28 zwang28 commented Dec 24, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

As titled.

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

Copy link
Contributor

@Li0k Li0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,thanks for the PR

@zwang28 zwang28 added this pull request to the merge queue Dec 24, 2024
Merged via the queue into main with commit 86c3933 Dec 24, 2024
39 of 40 checks passed
@zwang28 zwang28 deleted the wangzheng/fix_metric branch December 24, 2024 11:53
github-merge-queue bot pushed a commit that referenced this pull request Dec 25, 2024
github-merge-queue bot pushed a commit that referenced this pull request Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants