-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dashboard): improve relation & fragment graph #19872
base: main
Are you sure you want to change the base?
Conversation
4a728dd
to
4b14880
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
The relation graph looks a little crowded, but we may improve it later
// Layer 1: Keep existing d3-hierarchy layout for actors within fragments | ||
const layoutFragmentResult = new Map<string, FragmentLayout>() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason to keep this?
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Substitute dagre for our handwritten naive layout engine (
layout.ts
). Also redesigned the style of relation graph.Checklist
Documentation
Release note