Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dashboard): improve relation & fragment graph #19872

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

fuyufjh
Copy link
Member

@fuyufjh fuyufjh commented Dec 20, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Substitute dagre for our handwritten naive layout engine (layout.ts). Also redesigned the style of relation graph.

relation graph fragment graph

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

Base automatically changed from eric/dashboard_add_fragment_info to main December 23, 2024 09:40
@fuyufjh fuyufjh force-pushed the eric/new_style_of_relation_graph branch from 4a728dd to 4b14880 Compare December 23, 2024 09:56
Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool

@fuyufjh fuyufjh added this pull request to the merge queue Dec 24, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 24, 2024
Copy link
Member

@xxchan xxchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

The relation graph looks a little crowded, but we may improve it later

Comment on lines +122 to +123
// Layer 1: Keep existing d3-hierarchy layout for actors within fragments
const layoutFragmentResult = new Map<string, FragmentLayout>()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason to keep this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants