Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(log): print java exception stack trace in logger #19814

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

StrikeW
Copy link
Contributor

@StrikeW StrikeW commented Dec 16, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

LOG.error("Failed to execute JDBC statements, retried {} times", retryCount, e); doesn't print the stack trace. This pr fixes it.

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

@StrikeW StrikeW force-pushed the siyuan/fix-log4j-tracing branch from b7dd7b3 to ffad711 Compare December 16, 2024 13:50
@StrikeW StrikeW requested a review from BugenZhao December 16, 2024 13:50
@github-actions github-actions bot added the type/fix Bug fix label Dec 16, 2024
@StrikeW StrikeW requested a review from yezizp2012 December 16, 2024 13:51
@StrikeW StrikeW enabled auto-merge December 16, 2024 13:54
@StrikeW StrikeW added this pull request to the merge queue Dec 16, 2024
Merged via the queue into main with commit 4ed93eb Dec 16, 2024
40 of 41 checks passed
@StrikeW StrikeW deleted the siyuan/fix-log4j-tracing branch December 16, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants