Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add bench with join type and cache workload #19789

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

kwannoel
Copy link
Contributor

@kwannoel kwannoel commented Dec 12, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Add more benchmarks:

  1. Different amplification sizes.
  2. Different cache properties (not in cache / in cache).
  3. Different join types (outer / inner).

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

Copy link
Contributor Author

kwannoel commented Dec 12, 2024

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has totally checked 5501 files.

Valid Invalid Ignored Fixed
2312 1 3188 0
Click to see the invalid file list
  • src/stream/benches/stream_hash_join.py

src/stream/benches/stream_hash_join.py Show resolved Hide resolved
@kwannoel kwannoel force-pushed the 12-13-add_bench_with_join_type_and_cache_workload branch from 3676a59 to be9d6b1 Compare December 27, 2024 03:20
@kwannoel kwannoel marked this pull request as ready for review December 27, 2024 06:34
@kwannoel kwannoel force-pushed the 12-13-add_bench_with_join_type_and_cache_workload branch from 63656aa to f21aa13 Compare December 27, 2024 06:36
Copy link
Contributor

@chenzl25 chenzl25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants