Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add actor info to diagnose & dump diagnose on CI failure #19787

Merged
merged 9 commits into from
Dec 13, 2024
Merged

feat: add actor info to diagnose & dump diagnose on CI failure #19787

merged 9 commits into from
Dec 13, 2024

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Dec 12, 2024 •
edited
Loading

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

as title

motivation: so that we can better debug with the CN logs when CI failed.

(blocked by #19785

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

@xxchan
.
f8a138c 
Signed-off-by: xxchan <[email protected]>
@xxchan
..
4b27289 
Signed-off-by: xxchan <[email protected]>
@xxchan
...
2347c36 
Signed-off-by: xxchan <[email protected]>
@xxchan
....
d2a6d63 
Signed-off-by: xxchan <[email protected]>
@xxchan
>?
001788e 
Signed-off-by: xxchan <[email protected]>
@xxchan
1
c53f52b 
Signed-off-by: xxchan <[email protected]>
@xxchan
Copy link
Member Author

xxchan commented Dec 12, 2024 •
edited
Loading

works

image

@xxchan xxchan marked this pull request as ready for review December 12, 2024 14:01
@xxchan xxchan changed the title feat: add actor info to diagnose info & dump dianose on failure on ci feat: add actor info to diagnose & dump diagnose on CI failure Dec 12, 2024
@xxchan xxchan force-pushed the xxchan/hilarious-smelt branch from 8e926e2 to df5bd92 Compare December 12, 2024 14:03
@xxchan
Copy link
Member Author

xxchan commented Dec 12, 2024 •
edited
Loading

found a problem for CI: sqllogictest -j will drop databases 😅 (can be fixed by risinglightdb/sqllogictest-rs#236)

image

@graphite-app graphite-app bot requested a review from a team December 12, 2024 14:44
@xxchan
bump slt
4558308 
Signed-off-by: xxchan <[email protected]>
@xxchan xxchan added this pull request to the merge queue Dec 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 13, 2024
@xxchan xxchan added this pull request to the merge queue Dec 13, 2024
Merged via the queue into main with commit 6b800b4 Dec 13, 2024
32 of 33 checks passed
@xxchan xxchan deleted the xxchan/hilarious-smelt branch December 13, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zwang28 zwang28 zwang28 approved these changes

@BugenZhao BugenZhao BugenZhao approved these changes

@kwannoel kwannoel Awaiting requested review from kwannoel

@yezizp2012 yezizp2012 Awaiting requested review from yezizp2012

Assignees
No one assigned
Labels
ci/run-e2e-single-node-tests ci/run-e2e-test-other-backends type/feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xxchan @BugenZhao @zwang28