-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(stream): add hash join memory benchmarking for cache refill #19712
Merged
+370
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
kwannoel
changed the title
refactor hash join create executor utils
bench(stream): add hash join memory benchmarking for cache refill
Dec 9, 2024
9 tasks
kwannoel
commented
Dec 9, 2024
kwannoel
commented
Dec 9, 2024
kwannoel
commented
Dec 9, 2024
kwannoel
force-pushed
the
kwannoel/join-bench
branch
from
December 9, 2024 07:22
efda035
to
5d72e75
Compare
lmatz
approved these changes
Dec 9, 2024
lmatz
changed the title
bench(stream): add hash join memory benchmarking for cache refill
perf(stream): add hash join memory benchmarking for cache refill
Dec 10, 2024
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Add hash join memory benchmarking for cache refill. Prerequisite of #19629.
From
dhat-heap.json
(400K amp) here's the primary (64.87%):Here's the secondary (17.03%):
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.