Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: include subject in NATS source #19708

Merged
merged 7 commits into from
Dec 13, 2024

Conversation

PierreNowak
Copy link
Contributor

@PierreNowak PierreNowak commented Dec 8, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Ingest additional subject field for NATS source

CREATE source nats_source
INCLUDE subject as subject
WITH (
    connector='nats',
)...

now I have my subject column:

dev=> SELECT subject from nats_mv limit 10;
   subject
-------------
 data.SN0001
 data.SN0001
 data.SN0001
 data.SN0001
 data.SN0001
 data.SN0001
 data.SN0001
 data.SN0001
 data.SN0001
 data.SN0001
(10 rows)

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

as describe in title

support additional column dedicated to Nats Connector

CREATE SOURCE/TABLE <name> 
INCLUDE subject 
WITH (connector = 'nats', ...) ...;

subject stands for the message comes from which subject if the stream contains multiple subjects.

@PierreNowak PierreNowak changed the title include subject in NATS source feat: include subject in NATS source Dec 8, 2024
Copy link
Member

@fuyufjh fuyufjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea LGTM. Please also take a look cc. @tabVersion @xiangjinwu

@tabVersion
Copy link
Contributor

Hi @PierreNowak , I submit a pr to fix the format issue and add nats related E2E test.
PierreNowak#1
Thanks for your contribution.

@graphite-app graphite-app bot requested a review from a team December 9, 2024 09:26
@tabVersion
Copy link
Contributor

Hi @PierreNowak, can you merge PierreNowak#2 on your branch to merge this one? Thanks

@tabVersion tabVersion enabled auto-merge December 13, 2024 06:24
@tabVersion tabVersion added this pull request to the merge queue Dec 13, 2024
Merged via the queue into risingwavelabs:main with commit 5a85b55 Dec 13, 2024
32 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants