-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(connector): re-arrange the connector::parser
module for better readibility
#19697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
This stack of pull requests is managed by Graphite. Learn more about stacking. |
stdrc
changed the title
rename
refactor(connector): re-arrange Dec 6, 2024
util
to utils
connector::parser
module
stdrc
changed the title
refactor(connector): re-arrange
refactor(connector): re-arrange Dec 6, 2024
connector::parser
moduleconnector::parser
stdrc
changed the title
refactor(connector): re-arrange
refactor(connector): re-arrange the Dec 6, 2024
connector::parser
connector::parser
module to reduce its
stdrc
changed the title
refactor(connector): re-arrange the
refactor(connector): re-arrange the Dec 6, 2024
connector::parser
module to reduce its connector::parser
module to
stdrc
changed the title
refactor(connector): re-arrange the
refactor(connector): re-arrange the Dec 6, 2024
connector::parser
module to connector::parser
module for better readibility
Signed-off-by: Richard Chien <[email protected]>
xiangjinwu
approved these changes
Dec 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
9 tasks
tabVersion
approved these changes
Dec 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
9 tasks
stdrc
added a commit
that referenced
this pull request
Dec 9, 2024
…tter readibility (#19697) Signed-off-by: Richard Chien <[email protected]>
This was referenced Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
There were too many unrelated things inside
connector/src/parser/mod.rs
, this PR moves some relatively independent units into separate submodules.Only moves code, no other changes.
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.