Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(connector): re-arrange the connector::parser module for better readibility #19697

Merged
merged 8 commits into from
Dec 6, 2024

Conversation

stdrc
Copy link
Member

@stdrc stdrc commented Dec 6, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

There were too many unrelated things inside connector/src/parser/mod.rs, this PR moves some relatively independent units into separate submodules.

Only moves code, no other changes.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

stdrc added 7 commits December 5, 2024 15:53
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
@stdrc stdrc changed the title rename util to utils refactor(connector): re-arrange connector::parser module Dec 6, 2024
@stdrc stdrc changed the title refactor(connector): re-arrange connector::parser module refactor(connector): re-arrange connector::parser Dec 6, 2024
@stdrc stdrc changed the title refactor(connector): re-arrange connector::parser refactor(connector): re-arrange the connector::parser module to reduce its Dec 6, 2024
@stdrc stdrc changed the title refactor(connector): re-arrange the connector::parser module to reduce its refactor(connector): re-arrange the connector::parser module to Dec 6, 2024
@stdrc stdrc changed the title refactor(connector): re-arrange the connector::parser module to refactor(connector): re-arrange the connector::parser module for better readibility Dec 6, 2024
@stdrc stdrc marked this pull request as ready for review December 6, 2024 04:56
Signed-off-by: Richard Chien <[email protected]>
Copy link
Contributor

@xiangjinwu xiangjinwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@tabVersion tabVersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@stdrc stdrc added this pull request to the merge queue Dec 6, 2024
Merged via the queue into main with commit 7333427 Dec 6, 2024
29 of 30 checks passed
@stdrc stdrc deleted the rc/rearrange-connector-parser branch December 6, 2024 08:17
stdrc added a commit that referenced this pull request Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants