Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mssql-cdc): remove vendored-openssl of tiberus #18013

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

KeXiangWang
Copy link
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Change vendored-openssl to rustls for tiberus. rustls is more friendly for compling, previous discussion. After double checking, both of them can work and it was native-tls doesn't work for Azure Sql Server. Thanks to @xxchan's remind.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@KeXiangWang KeXiangWang requested a review from a team as a code owner August 13, 2024 03:14
@KeXiangWang KeXiangWang requested review from hzxa21 and xxchan August 13, 2024 03:14
@github-actions github-actions bot added the type/fix Bug fix label Aug 13, 2024
@KeXiangWang KeXiangWang changed the title fix(mssql-cdc): remove vendored-openssl fix(mssql-cdc): remove vendored-openssl of tiberus Aug 13, 2024
Copy link
Member

@xxchan xxchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@KeXiangWang KeXiangWang enabled auto-merge August 13, 2024 03:16
@KeXiangWang KeXiangWang added this pull request to the merge queue Aug 13, 2024
Merged via the queue into main with commit cad31da Aug 13, 2024
32 of 33 checks passed
@KeXiangWang KeXiangWang deleted the wkx/fix-vendored-openssl branch August 13, 2024 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants