Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dashboard): add suscription in catalog #16747

Merged
merged 3 commits into from
May 14, 2024
Merged

Conversation

xxhZs
Copy link
Contributor

@xxhZs xxhZs commented May 14, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

#16469

微信图片_20240514160916 微信图片_20240514160927

Please do not leave this empty!

Please explain IN DETAIL what the changes are in this PR and why they are needed:

  • Summarize your change (mandatory)
  • How does this PR work? Need a brief introduction for the changed logic (optional)
  • Describe clearly one logical change and avoid lazy messages (optional)
  • Describe any limitations of the current code (optional)
  • Refer to a related PR or issue link (optional)

-->

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@xxhZs xxhZs requested a review from yezizp2012 May 14, 2024 08:17
Copy link
Member

@yezizp2012 yezizp2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@yezizp2012 yezizp2012 requested review from fuyufjh and xxchan May 14, 2024 08:28
@xxhZs xxhZs enabled auto-merge May 14, 2024 08:36
@xxhZs xxhZs disabled auto-merge May 14, 2024 08:36
Copy link
Member

@fuyufjh fuyufjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@xxhZs xxhZs force-pushed the xxh/add-subscription-in-catalog branch from 08dc04e to 1adee44 Compare May 14, 2024 09:23
@xxhZs xxhZs enabled auto-merge May 14, 2024 09:24
fix ci

fix ci
@xxhZs xxhZs force-pushed the xxh/add-subscription-in-catalog branch from 1adee44 to 2ee99d8 Compare May 14, 2024 10:04
@xxhZs xxhZs added this pull request to the merge queue May 14, 2024
Merged via the queue into main with commit a0b2350 May 14, 2024
29 of 30 checks passed
@xxhZs xxhZs deleted the xxh/add-subscription-in-catalog branch May 14, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants