Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: install risedev to ci image #16161

Merged
merged 7 commits into from
Apr 8, 2024
Merged

ci: install risedev to ci image #16161

merged 7 commits into from
Apr 8, 2024

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Apr 5, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@xxchan xxchan requested a review from BugenZhao April 5, 2024 16:02
@xxchan xxchan enabled auto-merge April 5, 2024 16:04
Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about ./risedevs?

@xxchan xxchan requested a review from BugenZhao April 8, 2024 06:18
@xxchan xxchan added this pull request to the merge queue Apr 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 8, 2024
@xxchan xxchan added this pull request to the merge queue Apr 8, 2024
Merged via the queue into main with commit c317626 Apr 8, 2024
27 of 28 checks passed
@xxchan xxchan deleted the xxchan/monthly-giraffe branch April 8, 2024 08:31
@kwannoel
Copy link
Contributor

kwannoel commented Apr 11, 2024

This breaks some tests from running locally, since risedev may not be installed globally.

Minor issue I guess... can just add risedev to path locally.

@BugenZhao
Copy link
Member

This breaks some tests from running locally, since risedev may not be installed globally.

TBH I would expect the bash script to be a thin wrapper if possible, so that there's no such need to run "ci" script locally. I think #16244 (or #12451) is for this purpose. However we can install it to the path anyhow as a workaround for now. 🤣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants