refactor: bump await-tree to 0.2
#16035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
BugenZhao
commented
Apr 1, 2024
| @@ -744,8 +738,7 @@ impl LocalBarrierWorker { | |||
| pub fn spawn( | |||
| env: StreamEnvironment, | |||
| streaming_metrics: Arc<StreamingMetrics>, | |||
| await_tree_reg: Option<Arc<Mutex<await_tree::Registry<ActorId>>>>, | |||
| barrier_await_tree_reg: Option<Arc<Mutex<await_tree::Registry<u64>>>>, | |||
There was a problem hiding this comment.
These two registries are merged together and trees can be distinguished by key types.
xxchan
reviewed
Apr 1, 2024
| .map(|(k, v)| (k, v.to_string())) | ||
| .collect(); | ||
| let actor_traces = if let Some(reg) = self.stream_mgr.await_tree_reg() { | ||
| reg.collect::<Actor>() |
xxchan
approved these changes
Apr 1, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Signed-off-by: Bugen Zhao <[email protected]>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
yezizp2012
pushed a commit
that referenced
this pull request
Apr 7, 2024
Signed-off-by: Bugen Zhao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bugen Zhao [email protected]I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Improvements introduced in
await-tree0.2:Registrynow provides interior mutability. No need for wrapping likeArc<Mutex<..>>.This is a preparation for #14131.
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.