-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: opt-in steps with build.env rather than pr labels #13464
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is useful to use as part of a bisect tool for main-cron
. That is long overdue. It will not be able to bisect before this PR. But any commits after can be bisected with the help of this.
I will create a bisect pipeline which can be triggered adhoc.
Then using the functionality introduced from this PR, we can run specified tests via buildkite between specified commits.
It should not be automatically triggered, in case many tests fail due to some known reason.
+1 for trailing / leading comma to simplify regex. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
44edf21
to
40c4c70
Compare
content updated to cover most steps in pull-request and main-cron |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13464 +/- ##
==========================================
- Coverage 68.47% 68.41% -0.07%
==========================================
Files 1505 1505
Lines 259155 259155
==========================================
- Hits 177458 177289 -169
- Misses 81697 81866 +169
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM, thanks for this!
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Similar to #12870, but without the need to create a PR (e.g. #13457).
Example usage:
https://buildkite.com/risingwavelabs/pull-request#new
CI_STEPS=build,build-other,docslt,e2e-test
Notes about regular expression:
Buildkite conditionals (doc src) uses golang regexp package:
(^|,)
and(,|$$)
are used to prevent suffix and prefix match respectively. For examplemisc-check
shall not match/check/
andbuild-other
shall not match/build/
. Parentheses are required to evaluate alternation before concatenation.tests?
is used to accept both singulartest
and pluraltests
. Parentheses are not required because repetition already evaluates before concatenation. Similarly we allowbenchmarks?
andbackwards?
, but no other typos are tolerated./(^|,)(cpu-flamegraph|heap-flamegraph)(,|$$)/
is used to match eithercpu-flamegraph
orheap-flamegraph
. This is the only example where user do not need to manually specify the dependency stepflamegraph-env-build
. Note the use of one more pair of parentheses to evaluate alternation before concatenation.Tests runs:
CI_STEPS
, pipelinepull-request
shall include the same set of steps before this PR. (link)CI_STEPS
, pipelinemain-cron
shall include the same set of steps before this PR. (link)CI_STEPS=
, pipelinepull-request
runs the selected steps.build,build-other,docslt,e2e-test
(link)cpu-flamegraph
(link)regress-test,build,unit-tests,misc-check
(link)CI_STEPS=
, pipelinemain-cron
runs the selected steps.build,s3-source-test
(link)Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.