-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add WAIT
command
#13027
feat: add WAIT
command
#13027
Conversation
.is_empty() | ||
{ | ||
sleep(Duration::from_secs(1)).await; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The wait logic.
Codecov Report
@@ Coverage Diff @@
## main #13027 +/- ##
==========================================
- Coverage 68.69% 68.60% -0.10%
==========================================
Files 1495 1496 +1
Lines 251161 251257 +96
==========================================
- Hits 172546 172383 -163
- Misses 78615 78874 +259
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 18 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM. Should we support canceling wait
statement or set a maximum wait time to avoid a potential dead loop?
Will this command be user-facing? |
It's not a big deal. The loop will be cancelled once the gRPC connection closes, that is, the frontend cancels the request. |
Nope. Just for tests. |
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Closes #12885
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.