Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Refactor FsFetchExecutorBuilder to handle rate limiting #13006

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

tabVersion
Copy link
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

  • Modify FsFetchExecutorBuilder to handle FlowControlExecutor
  • Add rate limiting to FsFetchExecutor (the plan part is done here but left the exec part)

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

- Modify `FsFetchExecutorBuilder` to handle `FlowControlExecutor`
- Add rate limiting to `FsFetchExecutor`

Signed-off-by: tabVersion <[email protected]>
@tabVersion
Copy link
Contributor Author

following #12595

@tabVersion tabVersion enabled auto-merge October 23, 2023 09:16
@tabVersion tabVersion added this pull request to the merge queue Oct 23, 2023
@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #13006 (633e89f) into main (8b8c14c) will increase coverage by 0.08%.
Report is 4 commits behind head on main.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main   #13006      +/-   ##
==========================================
+ Coverage   68.71%   68.79%   +0.08%     
==========================================
  Files        1494     1494              
  Lines      250538   250542       +4     
==========================================
+ Hits       172152   172367     +215     
+ Misses      78386    78175     -211     
Flag Coverage Δ
rust 68.79% <0.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/stream/src/from_proto/source/fs_fetch.rs 0.00% <0.00%> (ø)

... and 19 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Merged via the queue into main with commit 2563300 Oct 23, 2023
8 of 9 checks passed
@tabVersion tabVersion deleted the tab/fetch-flow-control branch October 23, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants