Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove sqlx dependency #13002

Merged
merged 1 commit into from
Oct 23, 2023
Merged

chore: remove sqlx dependency #13002

merged 1 commit into from
Oct 23, 2023

Conversation

shanicky
Copy link
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

as title

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Signed-off-by: Shanicky Chen <[email protected]>
@shanicky shanicky requested a review from a team as a code owner October 23, 2023 07:58
@shanicky shanicky requested a review from yezizp2012 October 23, 2023 08:00
Copy link
Member

@fuyufjh fuyufjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for Cargo.lock

Copy link
Member

@yezizp2012 yezizp2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@xxchan xxchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it because it's unnecessary? indirectly depended by sea-orm?

@shanicky
Copy link
Contributor Author

Is it because it's unnecessary? indirectly depended by sea-orm?

We’re no longer directly dependent on sqlx, all connections are now using the seaorm wrapper.

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #13002 (67d676a) into main (8b8c14c) will increase coverage by 0.09%.
Report is 1 commits behind head on main.
The diff coverage is 1.56%.

@@            Coverage Diff             @@
##             main   #13002      +/-   ##
==========================================
+ Coverage   68.71%   68.80%   +0.09%     
==========================================
  Files        1494     1494              
  Lines      250538   250522      -16     
==========================================
+ Hits       172152   172381     +229     
+ Misses      78386    78141     -245     
Flag Coverage Δ
rust 68.80% <1.56%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/meta/src/error.rs 26.13% <ø> (+0.86%) ⬆️
src/meta/src/rpc/election/sql.rs 34.75% <1.56%> (+3.29%) ⬆️

... and 23 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shanicky shanicky added this pull request to the merge queue Oct 23, 2023
Merged via the queue into main with commit df0e017 Oct 23, 2023
9 of 10 checks passed
@shanicky shanicky deleted the peng/sqlx-remove branch October 23, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants