feat: add iceberg cdc test #12956
feat: add iceberg cdc test #12956
Conversation
ZENOTME
force-pushed
the
zj/cdc
branch
4 times, most recently
from
3d6df13 to
440a2d6
Compare
Codecov Report
@@ Coverage Diff @@
## main #12956 +/- ##
=======================================
Coverage 68.62% 68.63%
=======================================
Files 1496 1496
Lines 249967 249967
=======================================
+ Hits 171540 171562 +22
+ Misses 78427 78405 -22
Flags with carried forward coverage won't be shown. Click here to find out more. see 6 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
| GitGuardian id | Secret | Commit | Filename | |
|---|---|---|---|---|
| 7648795 | Generic CLI Secret | 7431f34 | integration_tests/iceberg-cdc/run_test.sh | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
ZENOTME
requested review from
liurenjie1024 and
wenym1
and removed request for
liurenjie1024
docker/docker-compose-latest.yml
Outdated
There was a problem hiding this comment.
docker/doceker-compose.yml use risingwave v1.2 and we haven't support iceberg upsert in that version. How about update it to v1.3?
There was a problem hiding this comment.
I think we should upgrade it to 1.3.
| rw_config = args['risingwave'] | ||
| cmd = f"sqllogictest -p {rw_config['port']} -d {rw_config['db']} {slt}" | ||
| print(f"Command line is [{cmd}]") | ||
| subprocess.run(cmd, | ||
| shell=True, | ||
| check=True) | ||
| time.sleep(10) | ||
| time.sleep(30) |
There was a problem hiding this comment.
Do we really need 30 seconds? How about modifying it to 15 secs?
| set -ex | ||
|
|
||
| # Start test environment. | ||
| docker-compose up -d |
There was a problem hiding this comment.
| docker-compose up -d | |
| docker-compose up -d --wait |
Wait for services to be ready.
| docker-compose up -d | ||
|
|
||
| # Wait for the environment to be ready. | ||
| sleep 20; |
| depends_on: | ||
| - minio-0 | ||
| - rest | ||
| build: ./spark |
There was a problem hiding this comment.
How about using images from icelake repo directly?
docker/docker-compose-latest.yml
Outdated
There was a problem hiding this comment.
I think we should upgrade it to 1.3.
ZENOTME
force-pushed
the
zj/cdc
branch
2 times, most recently
from
98ddea4 to
2ae7b59
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.