Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(release): install javadoc in release script #12949

Merged
merged 3 commits into from
Oct 18, 2023

Conversation

huangjw806
Copy link
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

fix connector compilation error.

https://buildkite.com/risingwavelabs/main-cron/builds/948#018b41e4-2a53-4f4d-9c57-92daf8cd93d7

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

@github-actions github-actions bot added the type/fix Bug fix label Oct 18, 2023
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #12949 (ed2fb9e) into main (878ebac) will decrease coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main   #12949      +/-   ##
==========================================
- Coverage   68.63%   68.63%   -0.01%     
==========================================
  Files        1496     1496              
  Lines      249717   249717              
==========================================
- Hits       171383   171381       -2     
- Misses      78334    78336       +2     
Flag Coverage Δ
rust 68.63% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@huangjw806 huangjw806 enabled auto-merge October 18, 2023 11:02
@huangjw806 huangjw806 added this pull request to the merge queue Oct 18, 2023
Merged via the queue into main with commit 272ce88 Oct 18, 2023
6 of 7 checks passed
@huangjw806 huangjw806 deleted the jianwei/fix-release-connector-javadoc branch October 18, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants