refactor(meta): split meta into smaller crates (step 1) #12924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just trying my idea quickly. Feel free to leave any comments/concerns. I came up with this idea because I thought `async_trait` is a major reason of the slow compilation (#9553 (comment)). There are many `async_trait`s in tonic services, and many heavy futures to type check. We can hardly get rid of them, but maybe we can split the services into crates so that we can compile them in parallel. (a little similar to #12485, but different) As a first step, split out: - `meta/service`: tonic grpc service implementations. We may further split this into parallel sub-crates. - `meta/node`: the server binary ### Result compiling only meta takes 50s -> 42s compiling pb -> cmd_all takes 92s -> 76s ### Note In order to quickly pass compilation, some brute force is used: - All `pub(crate)` are simply replaced with `pub`. - `use risingwave_meta::*` is used without careful fine-graind imports.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
license-eye has totally checked 4280 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 1904 | 1 | 2375 | 0 |
Click to see the invalid file list
- src/meta/service/src/mod.rs
Codecov Report
@@ Coverage Diff @@
## main #12924 +/- ##
==========================================
- Coverage 69.19% 68.58% -0.62%
==========================================
Files 1493 1494 +1
Lines 246484 249286 +2802
==========================================
+ Hits 170560 170964 +404
- Misses 75924 78322 +2398
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
BugenZhao
reviewed
Oct 18, 2023
🤔️ It took me about 2h to do this. Steps were:
As you can see the diff of this PR is also very reviewable, so it's a relatively easy refactor. I think it should mainly because the dependency |
There was a problem hiding this comment.
license-eye has totally checked 4281 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 1904 | 1 | 2376 | 0 |
Click to see the invalid file list
- src/meta/service/src/mod.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Just trying my idea quickly. Feel free to leave any comments/concerns. Will proceed if the idea sounds good.
I came up with this idea because I thought
async_traitis a major reason of the slow compilation (#9553 (comment)). There are manyasync_traits in tonic services, and many heavy futures to type check. We can hardly get rid of them, but maybe we can split the services into crates so that we can compile them in parallel. (a little similar to #12485, but different)As a first step, split out:
meta/service: tonic grpc service implementations. We may further split this into parallel sub-crates.meta/node: the server binaryResult
A rough manual test:
compiling only meta takes 50s -> 42s
compiling pb -> cmd_all takes 92s -> 76s
Before
After
Note
In order to quickly pass compilation, some brute force is used:
pub(crate)are simply replaced withpub.use risingwave_meta::*is used without careful fine-graind imports.Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.