Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mysql-cdc): set mysql connection timezone to UTC #12729

Merged
merged 3 commits into from
Oct 11, 2023

Conversation

StrikeW
Copy link
Contributor

@StrikeW StrikeW commented Oct 10, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

As title.
Test locally.
close #12710

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@StrikeW StrikeW requested review from lmatz and xiangjinwu October 10, 2023 08:33
@xiangjinwu xiangjinwu self-requested a review October 10, 2023 08:56
@xiangjinwu xiangjinwu linked an issue Oct 10, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #12729 (424d212) into main (615f873) will increase coverage by 0.00%.
Report is 4 commits behind head on main.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main   #12729   +/-   ##
=======================================
  Coverage   69.41%   69.41%           
=======================================
  Files        1473     1474    +1     
  Lines      242568   242599   +31     
=======================================
+ Hits       168376   168398   +22     
- Misses      74192    74201    +9     
Flag Coverage Δ
rust 69.41% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/frontend/src/optimizer/logical_optimization.rs 97.98% <100.00%> (+0.02%) ⬆️
...rc/frontend/src/optimizer/plan_node/generic/agg.rs 92.21% <100.00%> (ø)
...frontend/src/optimizer/rule/agg_call_merge_rule.rs 100.00% <100.00%> (ø)
src/frontend/src/optimizer/rule/mod.rs 100.00% <ø> (ø)

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@StrikeW StrikeW added this pull request to the merge queue Oct 11, 2023
Merged via the queue into main with commit d6c3280 Oct 11, 2023
6 of 7 checks passed
@StrikeW StrikeW deleted the siyuan/fix-mysql-cdc-timezone branch October 11, 2023 01:26
lmatz pushed a commit that referenced this pull request Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(source): use forceConnectionTimeZoneToSession for mysql-cdc
2 participants