Skip to content

Commit

Permalink
chore: replace the rfc link in nested-loop errors with the user doc l…
Browse files Browse the repository at this point in the history
…ink (#16682)
  • Loading branch information
neverchanje authored May 10, 2024
1 parent 763b393 commit ffb8a0a
Show file tree
Hide file tree
Showing 6 changed files with 10 additions and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
stream_error: |-
Not supported: streaming nested-loop join
HINT: The non-equal join in the query requires a nested-loop join executor, which could be very expensive to run. Consider rewriting the query to use dynamic filter as a substitute if possible.
See also: https://github.com/risingwavelabs/rfcs/blob/main/rfcs/0033-dynamic-filter.md
See also: https://docs.risingwave.com/docs/current/sql-pattern-dynamic-filters/
- name: With Simple Agg upstream materialized view on inner side
before:
- create_tables
Expand Down Expand Up @@ -97,7 +97,7 @@
stream_error: |-
Not supported: streaming nested-loop join
HINT: The non-equal join in the query requires a nested-loop join executor, which could be very expensive to run. Consider rewriting the query to use dynamic filter as a substitute if possible.
See also: https://github.com/risingwavelabs/rfcs/blob/main/rfcs/0033-dynamic-filter.md
See also: https://docs.risingwave.com/docs/current/sql-pattern-dynamic-filters/
- name: Ensure error on output columns from inner
before:
- create_tables
Expand All @@ -111,7 +111,7 @@
stream_error: |-
Not supported: streaming nested-loop join
HINT: The non-equal join in the query requires a nested-loop join executor, which could be very expensive to run. Consider rewriting the query to use dynamic filter as a substitute if possible.
See also: https://github.com/risingwavelabs/rfcs/blob/main/rfcs/0033-dynamic-filter.md
See also: https://docs.risingwave.com/docs/current/sql-pattern-dynamic-filters/
- name: Use Inner Join for equi condition
before:
- create_tables
Expand Down
2 changes: 1 addition & 1 deletion src/frontend/planner_test/tests/testdata/output/expr.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -648,7 +648,7 @@
stream_error: |-
Not supported: streaming nested-loop join
HINT: The non-equal join in the query requires a nested-loop join executor, which could be very expensive to run. Consider rewriting the query to use dynamic filter as a substitute if possible.
See also: https://github.com/risingwavelabs/rfcs/blob/main/rfcs/0033-dynamic-filter.md
See also: https://docs.risingwave.com/docs/current/sql-pattern-dynamic-filters/
- name: without variadic keyword
sql: |
create table t(a varchar, b varchar);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@
stream_error: |-
Not supported: streaming nested-loop join
HINT: The non-equal join in the query requires a nested-loop join executor, which could be very expensive to run. Consider rewriting the query to use dynamic filter as a substitute if possible.
See also: https://github.com/risingwavelabs/rfcs/blob/main/rfcs/0033-dynamic-filter.md
See also: https://docs.risingwave.com/docs/current/sql-pattern-dynamic-filters/
- id: aggregate with over clause, without ORDER BY and frame definition
sql: |
create table t(x int, y int, z int, w int);
Expand Down
6 changes: 3 additions & 3 deletions src/frontend/planner_test/tests/testdata/output/subquery.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -439,7 +439,7 @@
stream_error: |-
Not supported: streaming nested-loop join
HINT: The non-equal join in the query requires a nested-loop join executor, which could be very expensive to run. Consider rewriting the query to use dynamic filter as a substitute if possible.
See also: https://github.com/risingwavelabs/rfcs/blob/main/rfcs/0033-dynamic-filter.md
See also: https://docs.risingwave.com/docs/current/sql-pattern-dynamic-filters/
- sql: |
SELECT 1 a, (SELECT regexp_matches('barbeque barbeque', '(bar)(beque)', 'g')) b
optimized_logical_plan_for_batch: |-
Expand Down Expand Up @@ -658,7 +658,7 @@
stream_error: |-
Not supported: streaming nested-loop join
HINT: The non-equal join in the query requires a nested-loop join executor, which could be very expensive to run. Consider rewriting the query to use dynamic filter as a substitute if possible.
See also: https://github.com/risingwavelabs/rfcs/blob/main/rfcs/0033-dynamic-filter.md
See also: https://docs.risingwave.com/docs/current/sql-pattern-dynamic-filters/
- name: test over window subquery 3
sql: |
CREATE TABLE integers(i INTEGER);
Expand Down Expand Up @@ -715,7 +715,7 @@
stream_error: |-
Not supported: streaming nested-loop join
HINT: The non-equal join in the query requires a nested-loop join executor, which could be very expensive to run. Consider rewriting the query to use dynamic filter as a substitute if possible.
See also: https://github.com/risingwavelabs/rfcs/blob/main/rfcs/0033-dynamic-filter.md
See also: https://docs.risingwave.com/docs/current/sql-pattern-dynamic-filters/
- name: test over window subquery 5
sql: |
CREATE TABLE integers(i INTEGER, correlated_col int);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -213,4 +213,4 @@
stream_error: |-
Not supported: streaming nested-loop join
HINT: The non-equal join in the query requires a nested-loop join executor, which could be very expensive to run. Consider rewriting the query to use dynamic filter as a substitute if possible.
See also: https://github.com/risingwavelabs/rfcs/blob/main/rfcs/0033-dynamic-filter.md
See also: https://docs.risingwave.com/docs/current/sql-pattern-dynamic-filters/
3 changes: 1 addition & 2 deletions src/frontend/src/optimizer/plan_node/logical_join.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1339,10 +1339,9 @@ impl ToStream for LogicalJoin {
} else {
Err(RwError::from(ErrorCode::NotSupported(
"streaming nested-loop join".to_string(),
// TODO: replace the link with user doc
"The non-equal join in the query requires a nested-loop join executor, which could be very expensive to run. \
Consider rewriting the query to use dynamic filter as a substitute if possible.\n\
See also: https://github.com/risingwavelabs/rfcs/blob/main/rfcs/0033-dynamic-filter.md".to_owned(),
See also: https://docs.risingwave.com/docs/current/sql-pattern-dynamic-filters/".to_owned(),
)))
}
}
Expand Down

0 comments on commit ffb8a0a

Please sign in to comment.