Skip to content

Commit

Permalink
chore: fix some typos (#19710)
Browse files Browse the repository at this point in the history
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: xxchan <[email protected]>
Co-authored-by: xxchan <[email protected]>
  • Loading branch information
stdrc and xxchan authored Dec 9, 2024
1 parent 9b26a96 commit 430fbb9
Show file tree
Hide file tree
Showing 8 changed files with 10 additions and 12 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/typo.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,4 @@ jobs:
uses: actions/checkout@v4

- name: Check spelling of the entire repository
uses: crate-ci/typos@v1.23.2
uses: crate-ci/typos@v1.28.2
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ repos:
exclude: 'src/frontend/planner_test/tests/testdata/.*'
- id: trailing-whitespace
- repo: https://github.com/crate-ci/typos
rev: v1.23.1
rev: v1.28.2
hooks:
- id: typos
- repo: local
Expand Down
2 changes: 1 addition & 1 deletion Makefile.toml
Original file line number Diff line number Diff line change
Expand Up @@ -1158,7 +1158,7 @@ fi
private = true
category = "RiseDev - Check"
description = "Run cargo typos-cli check"
install_crate = { min_version = "1.23.2", crate_name = "typos-cli", binary = "typos", test_arg = [
install_crate = { min_version = "1.28.2", crate_name = "typos-cli", binary = "typos", test_arg = [
"--help",
], install_command = "binstall" }
script = """
Expand Down
2 changes: 1 addition & 1 deletion src/common/src/config.rs
Original file line number Diff line number Diff line change
Expand Up @@ -869,7 +869,7 @@ pub struct StorageConfig {
#[serde(default = "default::storage::mem_table_spill_threshold")]
pub mem_table_spill_threshold: usize,

/// The concurrent uploading number of `SSTables` of buidler
/// The concurrent uploading number of `SSTables` of builder
#[serde(default = "default::storage::compactor_concurrent_uploading_sst_count")]
pub compactor_concurrent_uploading_sst_count: Option<usize>,

Expand Down
2 changes: 1 addition & 1 deletion src/config/docs.md
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ This page is automatically generated by `./risedev generate-example-config`
| block_cache_capacity_mb | DEPRECATED: This config will be deprecated in the future version, use `storage.cache.block_cache_capacity_mb` instead. | |
| check_compaction_result | | false |
| compact_iter_recreate_timeout_ms | | 600000 |
| compactor_concurrent_uploading_sst_count | The concurrent uploading number of `SSTables` of buidler | |
| compactor_concurrent_uploading_sst_count | The concurrent uploading number of `SSTables` of builder | |
| compactor_fast_max_compact_delete_ratio | | 40 |
| compactor_fast_max_compact_task_size | | 2147483648 |
| compactor_iter_max_io_retry_times | | 8 |
Expand Down
6 changes: 2 additions & 4 deletions src/connector/src/parser/chunk_builder.rs
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ use thiserror_ext::AsReport;
use super::MessageMeta;
use crate::parser::utils::{
extract_cdc_meta_column, extract_header_inner_from_meta, extract_headers_from_meta,
extreact_timestamp_from_meta,
extract_timestamp_from_meta,
};
use crate::source::{SourceColumnDesc, SourceColumnType, SourceMeta};

Expand Down Expand Up @@ -224,9 +224,7 @@ impl SourceStreamChunkRowWriter<'_> {
}
}
(_, &Some(AdditionalColumnType::Timestamp(_))) => match self.row_meta {
Some(row_meta) => {
Ok(A::output_for(extreact_timestamp_from_meta(row_meta.meta)))
}
Some(row_meta) => Ok(A::output_for(extract_timestamp_from_meta(row_meta.meta))),
None => parse_field(desc), // parse from payload
},
(_, &Some(AdditionalColumnType::CollectionName(_))) => {
Expand Down
2 changes: 1 addition & 1 deletion src/connector/src/parser/utils.rs
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ pub(super) async fn bytes_from_url(
}
}

pub fn extreact_timestamp_from_meta(meta: &SourceMeta) -> DatumRef<'_> {
pub fn extract_timestamp_from_meta(meta: &SourceMeta) -> DatumRef<'_> {
match meta {
SourceMeta::Kafka(kafka_meta) => kafka_meta.extract_timestamp(),
SourceMeta::DebeziumCdc(cdc_meta) => cdc_meta.extract_timestamp(),
Expand Down
4 changes: 2 additions & 2 deletions src/connector/src/source/reader/desc.rs
Original file line number Diff line number Diff line change
Expand Up @@ -117,13 +117,13 @@ impl SourceDescBuilder {
pub fn build(self) -> ConnectorResult<SourceDesc> {
let columns = self.column_catalogs_to_source_column_descs();

let psrser_config = SpecificParserConfig::new(&self.source_info, &self.with_properties)?;
let parser_config = SpecificParserConfig::new(&self.source_info, &self.with_properties)?;

let source = SourceReader::new(
self.with_properties,
columns.clone(),
self.connector_message_buffer_size,
psrser_config,
parser_config,
)?;

Ok(SourceDesc {
Expand Down

0 comments on commit 430fbb9

Please sign in to comment.