Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix panic on nil standalone statefulset #586

Merged
merged 1 commit into from
Jan 23, 2024
Merged

fix: fix panic on nil standalone statefulset #586

merged 1 commit into from
Jan 23, 2024

Conversation

arkbriar
Copy link
Collaborator

What's changed and what's your intention?

PLEASE DO NOT LEAVE THIS EMPTY !!!

Please explain IN DETAIL what the changes are in this PR and why they are needed:

  • As title. Before this change, the reconciliation will finally work but may be delayed a lot due to exponential backoff.

Checklist

  • I have written the necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

@arkbriar arkbriar requested review from wjf3121 and CAJan93 January 23, 2024 05:44
wjf3121
wjf3121 approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@wjf3121 wjf3121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@arkbriar arkbriar added this pull request to the merge queue Jan 23, 2024
Merged via the queue into main with commit 7da9f57 Jan 23, 2024
10 of 11 checks passed
@arkbriar arkbriar deleted the shunjie/fix-panic-on-standalone-deployment branch January 23, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjf3121 wjf3121 wjf3121 approved these changes

@CAJan93 CAJan93 Awaiting requested review from CAJan93

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arkbriar @wjf3121