Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add links directing to integrations #98

Merged
merged 4 commits into from
Dec 4, 2024
Merged

Add links directing to integrations #98

merged 4 commits into from
Dec 4, 2024

Conversation

WanYixian
Copy link
Collaborator

@WanYixian WanYixian commented Nov 28, 2024

Description

As suggested in slack, update the sidebar. Click preview to check if this is the ideal result, let me know if any comments, thanks!

  1. Under Guides tab, add 3 auto-direct pages pointing to Integrations tab:
image image image
  1. Under Integrations tab, link back to Guides tab.

But these are landing pages with card components matching the left-side toc precisely. Adding 3 extra pages like above may mess it up, so add one-line description for each to link back to Guides.
image

image image

Copy link
Member

@xxchan xxchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about we also add link back to source/sink docs in "integration"'s sidebar?

mint.json Outdated
@@ -422,6 +423,7 @@
"group": "Process data",
"pages": [
"processing/overview",
"processing/sql-references",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

put it under "sql"?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

put it under "sql"?

Updated, but putting the auto-direct page like this as the first item under a section doesn't work well, so I moved it to the last one under SQL section
image

@WanYixian
Copy link
Collaborator Author

WanYixian commented Dec 2, 2024

What about we also add link back to source/sink docs in "integration"'s sidebar?

Updated, thanks!

BTW, This overview serves as the landing page for its subsections, so instead of adding one page paralleled with it to link back to source, I included a one-line description within it.
image

@xxchan xxchan requested review from stdrc and fuyufjh December 2, 2024 10:23
@WanYixian
Copy link
Collaborator Author

Please help take a look at your earliest convenience, thank you 😃

@WanYixian WanYixian merged commit 6c4249c into main Dec 4, 2024
3 of 4 checks passed
@WanYixian WanYixian deleted the wyx/add-direct-link branch December 4, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants