Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clarify behavior of agg funcs regarding to nulls #78

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

stdrc
Copy link
Member

@stdrc stdrc commented Nov 25, 2024

Copy link
Collaborator

@WanYixian WanYixian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, wondering if it's safe to replace "no non-null values" with "no valid values" in this context 🤔

@stdrc
Copy link
Member Author

stdrc commented Nov 25, 2024

wondering if it's safe to replace "no non-null values" with "no valid values" in this context 🤔

Not safe. null is a term in SQL, "no non-null values" is more accurate and professional than "no valid values".

@stdrc stdrc merged commit d197f8a into main Nov 25, 2024
2 checks passed
@stdrc stdrc deleted the rc/agg-function-nulls branch November 25, 2024 08:13
@WanYixian
Copy link
Collaborator

wondering if it's safe to replace "no non-null values" with "no valid values" in this context 🤔

Not safe. null is a term in SQL, "no non-null values" is more accurate and professional than "no valid values".

Yeah non-null is commonly seen, but "no non-null" seems not that immediately clear.
Since no other precise alternative, let's stick with "no non-null".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants