Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc CLI option for license key #49

Merged
merged 3 commits into from
Nov 20, 2024
Merged

Doc CLI option for license key #49

merged 3 commits into from
Nov 20, 2024

Conversation

WanYixian
Copy link
Collaborator

Description

Doc CLI option for license key

Related code PR

risingwavelabs/risingwave#18768

Related doc issue

Resolve #52

@@ -58,6 +58,13 @@ SELECT rw_test_paid_tier();

A result of `t` means the key is valid; an error message indicates an invalid key.

### CLI option for license key
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we'd better merge this section into ### Set license key as an alternative (and automated) method of setting the license key.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated, please take another look


To set your license key automatically:

1. Use the `--license-key-file` CLI option for the meta node to monitor and reload the license key from a specified file. This streamlines license key rotation in Cloud environments.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--license-key-file was later renamed to --license-key-path to be consistent with the env var key in risingwavelabs/risingwave#18838. Would you help to update it? Same for other occurrences.

Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WanYixian WanYixian merged commit 75c9f1b into main Nov 20, 2024
2 checks passed
@WanYixian WanYixian deleted the wyx/resolve_2673 branch November 20, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document: feat(meta): watch and reload license key from file
2 participants