Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use AWS_MSK_IAM as properties.sasl.mechanism for MSK source #103

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

tabVersion
Copy link
Contributor

No description provided.

Signed-off-by: Bohan Zhang <[email protected]>
Copy link
Collaborator

@WanYixian WanYixian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tabVersion
Copy link
Contributor Author

LGTM

Do we need to fix the AWS Amplify Console Web Preview check?

@WanYixian
Copy link
Collaborator

LGTM

Do we need to fix the AWS Amplify Console Web Preview check?

Frontend team is working on this, we can directly merge it for now

@tabVersion tabVersion merged commit 94c88b9 into main Dec 2, 2024
3 of 4 checks passed
@tabVersion tabVersion deleted the tabVersion-patch-2 branch December 2, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants