bump 1.2.0 #14

xxchan · 2023-09-19T00:35:36Z

No description provided.

https://github.blog/2023-10-02-introducing-the-new-apple-silicon-powered-m1-macos-larger-runner-for-github-actions/

xxchan · 2023-10-11T02:20:57Z

wtf

BugenZhao · 2023-10-11T08:12:04Z

https://github.blog/2023-10-02-introducing-the-new-apple-silicon-powered-m1-macos-larger-runner-for-github-actions/

Wow, this is a very recent update.

BugenZhao · 2023-10-11T08:15:35Z

OpenSSL and rdkafka is really a nightmare...

xxchan · 2023-10-11T08:58:45Z

OpenSSL and rdkafka is really a nightmare...

I think this isn't their fault. More probably apple's. 🤡

xxchan · 2023-10-11T09:12:46Z

Because of this?

xxchan · 2023-10-11T09:17:07Z

(x86, failed to build cxx) There's no "-std=c++11" here 🤔️

xxchan · 2023-10-11T09:48:07Z

OpenSSL and rdkafka is really a nightmare...

I think this isn't their fault. More probably apple's. 🤡

Or homebrew's 🤡

github-actions · 2023-10-13T09:10:32Z

❌ @xxchan bottle request failed.

github-actions · 2023-10-13T09:12:00Z

❌ @xxchan bottle request failed.

github-actions · 2023-10-13T09:13:47Z

❌ @xxchan bottle request failed.

xxchan · 2023-10-14T15:57:20Z

Homebrew/brew#7248 This looks very similar

because compiling #include <stdlib.h> produces many warnings.

PostgreSQL's configure script adds Xcode SDK root -I/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include
Xcode SDK root is printed by xml2-config --cflags, which runs xcrun --show-sdk-path
Homebrew adds CLT SDK root -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX10.15.sdk

xxchan · 2023-10-14T15:59:05Z

Homebrew/homebrew-core#51949 (comment)

This sounds exactly the root of the problem

You might have issues if is CMake build is not set up to use std_cmake_args.

CMake is somewhat an unique build tool when it comes to the macOS SDK. In particular, if CMAKE_OSX_SYSROOT is not set then CMake makes its own choice of a SDK to use rather than rely on the compiler to handle it (which Homebrew shims). This can generally lead to bad things as Homebrew will still try to use its SDK choice through the compiler shims which means there is now a couple of different SDKs in the include path, and the ordering is likely all wrong too.

If passing std_cmake_args is not possible for some reason, then you can try just -DCMAKE_OSX_SYSROOT, or perhaps setting the SDKROOT env. If the bootstrap doesn’t cope well with either (which would warrant a bug report IMO) then unsetting HOMEBREW_SDKROOT should be safe to do here. It wouldn’t be for something like Python which has a python3_config binary.

xxchan · 2023-10-14T16:09:43Z

.github/workflows/tests.yml

+
+      - name: Failures Summary and Bottle Result
+        if: always()
+        uses: Homebrew/actions/failures-summary-and-bottle-result@master
+        with:
+          workdir: ${{ github.workspace }}
+          result_path: bottles/steps_output.txt
+          step_name: 'Build failure summary on ${{ matrix.os }}'
+          collapse: 'true'
+
      - name: Upload bottles as artifact
        if: always() && github.event_name == 'pull_request'
        uses: actions/upload-artifact@main
        with:
          name: bottles
          path: '*.bottle.*'
+
+      - name: Post comment 
+        uses: Homebrew/actions/post-comment@master
+        with:
+          token: ${{ github.token }}
+          issue: ${{ github.event.number }}
+          body: "@${{github.actor}} bottle request for ${{ runner.os }} (${{github.event.repository.html_url}}/actions/runs/${{github.run_id}})."
+          bot_body: "Bottle request for ${{ runner.os }} (${{github.event.repository.html_url}}/actions/runs/${{github.run_id}})."
+          bot: BrewTestBot
+


These are a little bit useful, but I still don't know how to let the CI fail

github-actions · 2023-10-14T16:11:31Z

@xxchan bottle request for macOS (https://github.com/risingwavelabs/homebrew-risingwave/actions/runs/6518670861).

github-actions · 2023-10-14T16:12:37Z

@xxchan bottle request for Linux (https://github.com/risingwavelabs/homebrew-risingwave/actions/runs/6518670861).

github-actions · 2023-10-14T16:13:37Z

@xxchan bottle request for macOS (https://github.com/risingwavelabs/homebrew-risingwave/actions/runs/6518670861).

github-actions · 2023-10-14T16:21:39Z

@xxchan bottle request for Linux (https://github.com/risingwavelabs/homebrew-risingwave/actions/runs/6518681323).

github-actions · 2023-10-14T16:21:41Z

@xxchan bottle request for macOS (https://github.com/risingwavelabs/homebrew-risingwave/actions/runs/6518681323).

BugenZhao · 2023-10-14T16:24:35Z

What an acute insight you have!

github-actions · 2023-10-14T16:33:15Z

@xxchan bottle request for macOS (https://github.com/risingwavelabs/homebrew-risingwave/actions/runs/6518681323).

github-actions · 2023-10-15T02:22:38Z

@xxchan bottle request for Linux (https://github.com/risingwavelabs/homebrew-risingwave/actions/runs/6521399980).

github-actions · 2023-10-15T02:36:34Z

@xxchan bottle request for macOS (https://github.com/risingwavelabs/homebrew-risingwave/actions/runs/6521399980).

github-actions · 2023-10-15T03:02:07Z

@xxchan bottle request for macOS (https://github.com/risingwavelabs/homebrew-risingwave/actions/runs/6521399980).

xxchan · 2023-10-15T03:07:29Z

macos-12 failed again... too much headache 🤡

BugenZhao · 2023-10-15T04:12:13Z

Why we get no Monterey 🤔

xxchan · 2023-10-15T07:21:09Z

Because macos-12 failed and I’m too lazy to fix it. 🤡

BugenZhao · 2023-10-17T03:49:59Z

Because macos-12 failed and I’m too lazy to fix it. 🤡

Only Ventura and Sonoma users can take benefits from pre-built bottles and others will suffer from build time of 30 minutes+. I'm okay with that though. 🤣

bump

ff1279b

xxchan added the pr-pull label Sep 19, 2023

xxchan changed the title ~~bump~~ bump 1.2.0 Sep 19, 2023

xxchan removed the pr-pull label Sep 19, 2023

xxchan added 2 commits October 11, 2023 10:06

uses the M1 runner

fc0d9d3

https://github.blog/2023-10-02-introducing-the-new-apple-silicon-powered-m1-macos-larger-runner-for-github-actions/

use large intel mac

a249782

xxchan added 5 commits October 11, 2023 10:31

?

59c521d

1

9af2c7f

try

fcfb615

fix

fddae9e

fix

4eecfb3

try try

96b8529

try try

ca5901e

xxchan added 2 commits October 11, 2023 17:34

try try

b0a2903

??

5edc7a6

xxchan added 7 commits October 12, 2023 09:47

what

bf00731

try removing llvm

60af498

?

0bcd321

fix

d604b1a

.....

43d6a10

?

a214998

try try fixing ci

347ccce

try try

aa1ea65

xxchan commented Oct 14, 2023

View reviewed changes

revert changes

5da85a7

try macos13-large

c03309a

xxchan added 2 commits October 15, 2023 10:34

remove comment

caf997a

add back macos-12

e0ad712

xxchan added the pr-pull label Oct 15, 2023

github-actions bot closed this in ad7b028 Oct 15, 2023

github-actions bot deleted the xxchan/relieved-baboon branch October 15, 2023 03:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bump 1.2.0 #14

bump 1.2.0 #14

xxchan commented Sep 19, 2023

xxchan commented Oct 11, 2023 •

edited

Loading

BugenZhao commented Oct 11, 2023

BugenZhao commented Oct 11, 2023

xxchan commented Oct 11, 2023

xxchan commented Oct 11, 2023

xxchan commented Oct 11, 2023

xxchan commented Oct 11, 2023

github-actions bot commented Oct 13, 2023

github-actions bot commented Oct 13, 2023

github-actions bot commented Oct 13, 2023

xxchan commented Oct 14, 2023

xxchan commented Oct 14, 2023

xxchan Oct 14, 2023

github-actions bot commented Oct 14, 2023

github-actions bot commented Oct 14, 2023

github-actions bot commented Oct 14, 2023

github-actions bot commented Oct 14, 2023

github-actions bot commented Oct 14, 2023

BugenZhao commented Oct 14, 2023

github-actions bot commented Oct 14, 2023

github-actions bot commented Oct 15, 2023

github-actions bot commented Oct 15, 2023

github-actions bot commented Oct 15, 2023

xxchan commented Oct 15, 2023

BugenZhao commented Oct 15, 2023

xxchan commented Oct 15, 2023

BugenZhao commented Oct 17, 2023

bump 1.2.0 #14

bump 1.2.0 #14

Conversation

xxchan commented Sep 19, 2023

xxchan commented Oct 11, 2023 • edited Loading

BugenZhao commented Oct 11, 2023

BugenZhao commented Oct 11, 2023

xxchan commented Oct 11, 2023

xxchan commented Oct 11, 2023

xxchan commented Oct 11, 2023

xxchan commented Oct 11, 2023

github-actions bot commented Oct 13, 2023

github-actions bot commented Oct 13, 2023

github-actions bot commented Oct 13, 2023

xxchan commented Oct 14, 2023

xxchan commented Oct 14, 2023

xxchan Oct 14, 2023

Choose a reason for hiding this comment

github-actions bot commented Oct 14, 2023

github-actions bot commented Oct 14, 2023

github-actions bot commented Oct 14, 2023

github-actions bot commented Oct 14, 2023

github-actions bot commented Oct 14, 2023

BugenZhao commented Oct 14, 2023

github-actions bot commented Oct 14, 2023

github-actions bot commented Oct 15, 2023

github-actions bot commented Oct 15, 2023

github-actions bot commented Oct 15, 2023

xxchan commented Oct 15, 2023

BugenZhao commented Oct 15, 2023

xxchan commented Oct 15, 2023

BugenZhao commented Oct 17, 2023

xxchan commented Oct 11, 2023 •

edited

Loading